[Systers-dev] Urgent bug and need for a test cycle

[Robin Jeffries]

Everyone,   Kanika Vats has fixed the bug, I have reviewed the code and am
asking for a few small changes.  We should be ready to merge tomorrow or
Friday at the latest, so if the Americans aren't all going on vacation (we
have a 3 day holiday coming up), we can test this weekend.

*Jason*, what we need for special tests for this -- you might want to create
a list and see if you can create the conditions for this test and add it to
the template for this time.

The bug is that if someone subscribes with an address that has upper case
letters in it, then when they go to change their settings (log in and try to
access the options page, or if the admin looks them up on the membership
management page, and tries to access the options page), mailman crashes.  So
we need to test with someone who has upper case letters in their name.

See if you can add someone to the list using mixed case (email should accept
any case in the email address, so it doesn't matter what the canonical form
of their email address is).  I fear that it is no longer possible to add
people with mixed case names (so the error only happens for long term
members).  If you can't, we will need to create a new list after the code is
merged, add a few people, and then I can work with you to go into the
database and manually change someone's email to mixed case.

THe tests we need are
1.  the person with the mixed case name (can be anyone who is given the name
and password, as all the feedback will be in the browser, not in email)
tries to log in and access their options page
2.  the admin goes to the admin page www.abiwt.org/mailman/admin/<listname>
then goes to membership management, searches for the person's name (do the
searching in lower case to make sure you find it), and then clicks on the
link to their name.  If it goes to the options page all is well.

I think those are the only two special tests we will need.

If you can play around and figure out how to write up these tests (if you do
it on abiwt, mailman will crash and restart itself.  You will see the "oops,
we hit a bug" error message) and get them into the template instance, that
will be great.  Once we have accepted Kanika Vats changes, then someone will
need to work with Jen to pull the changes over to abiwt, you can create the
needed lists and subscribers, and we are ready to test.  I have high hopes
that we can do the merge on Tuesday.  I'll leave it to you to figure out
when folks are available for testing etc.

Robin

On Tue, May 25, 2010 at 9:12 PM, Robin Jeffries <robin at jeffries.org> wrote:

>
>
> On Tue, May 25, 2010 at 2:24 PM, Jason Cox <jasonwilburcox at gmail.com>wrote:
>
>> Robin,
>>
>> I removed the tests you specified. I have a couple questions about two of
>> the groups below.
>>
>> On Tue, May 25, 2010 at 12:38 AM, Robin Jeffries <robin at jeffries.org>wrote:
>>
>>> I'm asking questions of lots of folks here.  Can you check for your name,
>>> please?
>>>
>>> (I think you only sent this to me, Jason.  )
>>>
>>> *Svaksha*, you can participate in the testing without a unix box.  90%
>>> of it involves either sending email or accessing the admin pages through
>>> your browser.  There are a few where it helps to have ssh access to get to
>>> the server and see if errors were logged or if the database was updated
>>> correctly, but if you don't have putty or the like on your machine, you can
>>> just not sign up for those.
>>> *
>>> Jason,* for the tests, i think we can *skip*
>>> ANVn (all of them)
>>> AMM3-9
>>> UOL1
>>> UOM4-8
>>>
>>
>> The new master list had a different 3 and 4. The tests are "Change primary
>> email address and name" and "Globally change primary email address and
>> name". They are both labelled optional. Do you want us to run these tests?
>>
>
> Nope, they are for non-dlists; we don't need to check anything non-dlist
>
>>
>>
>>
>>> UOCn (all of them -- this should have no impact on non-dlists, since it
>>> relates to the dlist database)
>>>
>>
>> The UOC tests are missing from the new master list. Should they be added
>> to the new master list? If so, I can take care of that.
>>
>
> They are now the UPM items (from Kathy's renumbering) and I believe I kept
> them.
>
> For the new UPC items, we just need 1-9.
>
> Robin
>
>>
>> Thanks,
>>
>> Jason
>>
>>
>>> ULPn (all of them)
>>> UPNn (all of them)
>>>
>>> That should make the test cycle pretty manageable.
>>>
>>> *Kathy Gee*, is this the right template?  Have we posted the one that
>>> has the 5 emails that have to be set up with subscribing to new
>>> conversations on/off in various combinations? While I don't think this bug
>>> impacts that part of the code, it's close enough that it would be nice to
>>> include that in the testing.  Jason, it should be easy to add the new tests,
>>> just by copying, if Kathy has the latest template somewhere not published
>>> yet.
>>>
>>> *Kanika Vats*, can you give us a progress report on where you are in
>>> fixing the bug and how soon you think you will be able to hand it off to the
>>> testers?
>>>
>>> *Jen*, what machine should we use for testing this?  abiwt.org or the
>>> new server?
>>>
>>> Robin
>>>
>>>
>>>
>>>
>>>
>>> On Mon, May 24, 2010 at 2:33 PM, Jason Cox <jasonwilburcox at gmail.com>wrote:
>>>
>>>> All,
>>>>
>>>> I have created a new checklist page for testing the bug on the wiki here
>>>> systers.org/systers-dev/doku.php/checklist_specific_for_bug_583379.
>>>> Robin, let me know which items don't belong for this test, and I can remove
>>>> them from the list. I haven't created any lists yet, in case we are using
>>>> the new server for this.
>>>>
>>>> As far as the actual tests go, information on the process can be found
>>>> here systers.org/systers-dev/doku.php/how_to_test_things and here
>>>> systers.org/systers-dev/doku.php/tests. A checklist is used (linked
>>>> above) to record the results of each test. There are several tests separated
>>>> into several categories. When we are ready for testing, we will figure out
>>>> who will do which test. Some tests only require one person, but some require
>>>> a few people to work together. For the multi-person tests, we will
>>>> coordinate with each other through IRC or gchat, send some emails, make
>>>> changes, send more emails, and keep each other informed on whether or not an
>>>> email is received.
>>>>
>>>> Thanks for the interest in helping with testing Yian and Malveeka!
>>>> Svaksha, if you get back to a Linux box in time, you can help as well. :)
>>>> When the patched server is ready, we can coordinate a time to meet in IRC
>>>> for testing.
>>>>
>>>> Thank You,
>>>>
>>>> Jason Cox
>>>>
>>>> On Fri, May 21, 2010 at 12:34 AM, Robin Jeffries <robin at jeffries.org>wrote:
>>>>
>>>>> We've found an important bug that needs to be fixed ASAP.
>>>>>
>>>>> A syster tried to access her mailman options page and caused mailman to
>>>>> die.
>>>>>  Kanika vats and I did some poking around, and the problem is that she
>>>>> has
>>>>> an email address in the dlist database with upper case characters.
>>>>>  That
>>>>> didn't match the key we were searching on (which was all lower case),
>>>>> so we
>>>>> couldn't find her record, and mailman summarily crashed (luckily
>>>>> mailman
>>>>> does a great job of recovering from problems like this and restarts
>>>>> with
>>>>> almost no side effects).
>>>>>
>>>>> Kanika Vats is going to fix the problem (which apparently exists in
>>>>> several
>>>>> places; we never noticed it before because it's currently not possible
>>>>> to
>>>>> create a record with upper case letters in the email key, so none of
>>>>> our
>>>>> testing exposed this. ) She's doing it, a) because she found the
>>>>> problem,
>>>>> and b) because it is in the code she wrote last summer, though it looks
>>>>> like
>>>>> the problem existed before her changes.  We will need to pull this over
>>>>> to
>>>>> abiwt.org, our current testing machine, and run a mini test cycle on
>>>>> it, as
>>>>> quickly as we can.  (Jen, are we still using abiwt.org for integration
>>>>> testing, or should we be using the new machine?)
>>>>>
>>>>> For the test cycle, I'm hoping that Jason, who is the mentor for our
>>>>> testing
>>>>> project and Vidya, the student on that project, can use this as a
>>>>> chance to
>>>>> learn how testing works now (so you really know what you are trying to
>>>>> improve). We can take our current set of manual tests and pare this
>>>>> cycle
>>>>> down to just the ones that access the dlist database, plus a couple
>>>>> that
>>>>> test the core functionality (like the ability to send to the list).
>>>>>  I'm
>>>>> happy to work with you two to figure out what those tests are.  (This
>>>>> could
>>>>> get started now, so that we are ready to test when the code is done).
>>>>>
>>>>> Then we will need folks from this list to help with the testing.  It's
>>>>> probably only 4-5 hours work total, which, if we get lots of people, we
>>>>> can
>>>>> get done with about 30 minutes of work on the part of each tester.
>>>>>  Students, this will be a chance for you to learn about system testing,
>>>>> which will serve you well this summer, plus you will learn more about
>>>>> how
>>>>> mailman works, so I hope that all of you will participate.    I'll
>>>>> leave it
>>>>> to Vidya and Jason to organize that when we get this far, which I hope
>>>>> will
>>>>> be early next week.
>>>>>
>>>>> We are also going to use this to try out a code review.  I was hoping
>>>>> to
>>>>> have a bit more structure in place before doing it, but this gives me
>>>>> (as
>>>>> code reviewer) and kanika vats (as person being reviewed) a chance to
>>>>> figure
>>>>> out how to use the tools that launchpad provides.  We are going to
>>>>> expect
>>>>> everyone to have their code reviewed regularly this summer, so I'll try
>>>>> to
>>>>> be public about what we are learning, so that it will be easier for the
>>>>> rest
>>>>> of you.
>>>>>
>>>>> Thanks for your help on this.  It's always frustrating to have to do
>>>>> one of
>>>>> these test cycles outside the ones we plan for the summer (and where we
>>>>> give
>>>>> a lot more notice), but I think it turns out to be a great opportunity
>>>>> for
>>>>> people to learn more about how things work here in a lightweight way.
>>>>>  I
>>>>> appreciate everyone chipping in to make it go quickly and smoothly.
>>>>>
>>>>> Robin
>>>>>
>>>>>
>>>>> To unsubscribe from this conversation, send email to <
>>>>> systers-dev+urgent+unsubscribe at systers.org<systers-dev%2Burgent%2Bunsubscribe at systers.org>>
>>>>> or visit <
>>>>> http://systers.org/mailman/options/systers-dev?override=118&preference=0
>>>>> >
>>>>> To contribute to this conversation, use your mailer's reply-all or
>>>>> reply-group command or send your message to
>>>>> systers-dev+urgent at systers.org <systers-dev%2Burgent at systers.org>
>>>>> To start a new conversation, send email to <
>>>>> systers-dev+new at systers.org <systers-dev%2Bnew at systers.org>>
>>>>> To unsubscribe entirely from systers-dev, send email to <
>>>>> systers-dev-request at systers.org> with subject unsubscribe.
>>>>>
>>>>
>>>>
>>>
>>
>