[Systers-dev] Mailman bug #590155 + #495331

[Anna Granudd]

Hi,
I'm affraid I don't have a test case any more. I'm pretty sure I uploaded
one to the page listing the bug but like I said earlier all old bugs seem to
have gone missing of some reason so I can't find it any more. :P
Robin, do you have any idea how to reproduce the bug? I have a slight
feeling that the catch of this exception was introduced since I got the code
to throw this exception the first time it was run but after that it worked,
so I added it a bit like a "virgin run" (which would indicate the footer is
set first later of some reason I guess) but I might be wrong (I'm sure I
added an exception for this reason for one bug that I resolved but not
completley sure which one)... Sorry, I have a feeling I'm not of much help
here I'm affraid. Let me know if I can help you in some other way.

Anna

PS: just found a short bug descripiton of the old bug: "emails got through
to the archives and out through digest but didn't get send out to normal
subscribers. Problem occured only for non dlists."
For tips regarding some old bugs for you Erica (and please do add stuff to
this page if you have something you think might fit there), see this page:
http://systers.org/systers-soc/doku.php/bugs
The page was created since often the people having done development on
Mailman for a long time would recollect "that sounds familiar to some old
bug but I don't know how we fixed it any more" and we wanted to write these
fixes down somewhere so that newer developers didn't have to "invent the
wheel" again, so to speak or at least could get an idea of where to start.
:)


On Sat, Jun 19, 2010 at 7:51 PM, erica <erica at wobblingcat.com> wrote:

>  Hi all,
>
> Further research reveals that Anna made a fix that stopped a crash, but
> instead kicks out the error message that Robin was seeing per the initial
> comment in bug report 495331.  Here (
> http://bazaar.launchpad.net/~systers-soc/systers/stable/revision/71<http://bazaar.launchpad.net/%7Esysters-soc/systers/stable/revision/71>) is the revision in the stable branch which contains both the crash fix and
> error message.
>
> I was unable to reproduce the error message, hence the diagnostic patch I
> proposed.
>
> Anna, thanks for the background info, it was very helpful!  Do you have a
> test case for the crash?  I think it would be the test case for bug 495331
> as well.
>
> erica
>
>
> On 6/19/2010 3:41 AM, Anna Granudd wrote:
>
> Hi,
> On Fri, Jun 18, 2010 at 11:52 PM, Robin Jeffries <robin at jeffries.org>wrote:
>
>> For the footer message, it's possible that this bug got fixed and not
>> updated.  I haven't had time to track that down yet.  Will do this weekend
>> if events don't overwhelm me.
>>
>
> I checked bug #495331 and compared it to the fix Robin mentioned from last
> year (can be found here [1]) and it seems it is not the same bug after all
> (the old fix catches the exception and enters the empty string, it was a fix
> for a crash as a result of missing footers for non dlists if I recall
> correctly - the bug itself seems to have been deleted by Launchpad since it
> was fixed about a year ago), although it is really strange that the
> 'footer-text' got lost. I guess we need to find out where it should get set
> and why it's not any more...
>
> Anna
>
> [1]
> http://bazaar.launchpad.net/~systers-dev/systers/wishlist/revision/76#Mailman/Handlers/Decorate.py<http://bazaar.launchpad.net/%7Esysters-dev/systers/wishlist/revision/76#Mailman/Handlers/Decorate.py>
>
>
>
>
>