[Systers-dev] Proposal to split dlist handler

Robin Jeffries robin at jeffries.org
Wed Jul 14 22:22:09 PDT 2010


I think putting all the utility functions into DlistUtils makes sense.

Yes, I've assumed that something like this was the solution to these bugs;
thanks for figuring out the details.

Robin

On Wed, Jul 14, 2010 at 12:21 PM, Erica Wolfe <ericawolfe at gmail.com> wrote:

> Hello all,
>
> I would like some feedback on a fix I propose.
>
> While researching a pair of unsubscription bugs, 386133 and 3244206, I was
> only able to reproduce 324406.  However, I was able to determine that the
> problems stem from running dlist unsubscribe emails through all the Mailman
> handlers.  Expanding on the patch proposed by beachbrake, splitting the
> dlist handler into two parts resolves the issues so I created an early
> dlist
> handler and a late dlist handler.  The early dlist handler contains only
> the
> code to unsubscribe from dlists but I chose a generic name as I expect that
> other folks may wont to put code in the file at some point as well.  The
> late dlist handler contains everything except the unsubscribe
> functionality.  In addition, I created a dlist handler util file but can
> put
> that code into Mailman/DlistUtils if that is deemed more appropriate.
>
> Does this seem logical and reasonable to folks?
>
> Regards,
> erica
>
>
> To unsubscribe from this conversation, send email to <
> systers-dev+proposal+unsubscribe at systers.org<systers-dev%2Bproposal%2Bunsubscribe at systers.org>>
> or visit <
> http://systers.org/mailman/options/systers-dev?override=144&preference=0>
> To contribute to this conversation, use your mailer's reply-all or
> reply-group command or send your message to
> systers-dev+proposal at systers.org <systers-dev%2Bproposal at systers.org>
> To start a new conversation, send email to <systers-dev+new at systers.org<systers-dev%2Bnew at systers.org>
> >
> To unsubscribe entirely from systers-dev, send email to <
> systers-dev-request at systers.org> with subject unsubscribe.
>

To contribute to this conversation, send mail to <Erica Wolfe >


More information about the Systers-dev mailing list