[Systers-dev] bugs in Mailman

[Anna Granudd]

Hi,

On Fri, Sep 4, 2009 at 9:24 AM, kanika vats <kanika.krikan at gmail.com> wrote:

> Hello Anna,
>
>> Hi Kanika,
>> I'm not in the mood to reinstall everything including Mailman today to be
>> able to commit to the branch myself, but I do want to help to solve the
>> problems with the lists so I just downloaded the code to take a look at it.
>> I know you had your share of fun reinstalling everything as well this summer
>> so I think you understand why I don't want to do it again unless necessary.
>> :)
>
> So have you removed mailman already? Hehe..
>
>>
>>
Actually I thought I couldn't checkout your branch to the code on my
computer from my branch (since the code on my computer was already
associated with the wishlist branch and I had some issues with branches
before) but now that I tried it it seems to have worked fine getting your
code so I was able to run local tests with your code as well.


> For the dlist problem (list not becoming dlists), you might want to try
>> changing in row 672 and 763 in DlistUtils.py setting it to
>> mlist.dlists_enabled instead of just mlist.dlists (at least to make it
>> compatible with the things I wrote, mlist.dlists_enabled is referenced in
>> other files and not set if mlist.dlists is used instead --> possible
>> problems). I'm not sure this will make the trick since I only really quickly
>> took a look at the code between classes but it might be worth a shot.
>
> Yup changed that and the Dlist feature problem is solved ;).I knew you will
> be able to figure out this bug easily.
>
>> Also, I changed in my code so that the default value if the
>> mlist.dlists(_enabled) isn't set it automatically returns True in the
>> exception in row 674, I think this is a good thing to do to be on the safe
>> side with compitability with old lists so you might want to change this as
>> well. This looked like a small bug to me at least but like I said I haven't
>> tried it. Did you ever use mlist.dlists to anything else? Using grep I
>> couldn't find any other references but still?
>>
> Well I am not getting this change you made,have you committed this change
> to your  branch,if not can you mail me the file where you made the change so
> that I can reflect it in orm_objectoriented branch.
>
> No,I did not use mlist.dlists to anything else.
>
>>
>> I still haven't figured out what the deal with the debug_mode is, it's
>> really strange that it doesn't work. I mean, it's just a simple boolean
>> variable and an if-statement - how much wrong could one get it? :P I'll give
>> it some more thought though and let you know if I can think of something.
>>
> Yup right the debug mode problem is a strange thing,in your absence I was
> not able to figure out the reason myself...after all it's just a simple
> boolean variable and an if-statement :P.
>
>
I'm not sure I can localize the problem, running manual testing with the
code from the orm_objectoriented branch, the debug_mode works just fine and
so does your (Kanika's) code. However, checking the code on abiwt.org I
noticed that it's not the same as your branch (I think it contains
Malveeka's Storm branch which doesn't seem to be included in the
orm_objectoriented branch). This means I'm not sure how to continue. The
error doesn't seem to lie in the orm-branch at least since the local testing
showed no sign of it. Maybe I understood it wrong and have been looking at
and checking out the wrong branch? Sorry, I'm a bit tired and confused...


> @Jennifer can you please update the code at abiwt.org from
> orm_objectoriented branch.The Dlist feature bug is solved now.I guess we
> should start the final testing.
>
> Anna you can help me figure out the Debug mode problem during the
> testing....we can make subsequent commits and updates to get this thing
> working,this can perhaps save your time from reinstalling mailman
> locally.Lets decide on a meeting time on irc and we can together work on
> this DEBUG_MODE issue.
>
>
We can do that if you want to, otherwise since I now got the code we can
both continue locally on our computers. It's up to you.


> After next week my mid-semester exams will be starting and I will get very
> busy,so I really want this problem to get solved within this weekend and our
> code to get pushed to production :).Let me know if you are available Anna.
>
>
> PS:Jennifer we will require your help too ;>
>
> --
> Best Regards
> Kanika Vats
>

Thanks,
Anna